client: accept tool_results too #18
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise, an empty array is sent and Cohere relies on tool_results as being empty and therefore don't trigger tool_calls
| @@ -34,6 +34,7 @@ def chat( | |||
| frequency_penalty: nil, | |||
| presence_penalty: nil, | |||
| tools: [], | |||
| tool_results: nil, | |||
There was a problem hiding this comment.
I would personally put tool_results: [] and then below:
req.body[:tool_results] = tool_results if tool_results.any?| tools: tool, | ||
| tool_results: [ | ||
| { | ||
| rows: [['Ruby', 42]] |
There was a problem hiding this comment.
Is this correct format? The docs mention the following format:
tool_results = [
{
"call": {
"name": <tool name>,
"parameters": {
<param name>: <param value>
}
},
"outputs": [{
<key>: <value>
}]
},
...
]
|
@yjean Do you think you could add the missing spec for the |
otherwise, the conversation_id is ignored by Cohere
To restore behavior prior to 6/10/2024 change
|
@yjean Just making sure you saw my comments here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So Cohere can provide a reply based on the results of function calling.